BAH-4504 Add support for additional section on registration create patient page#95
Open
hamsavarthiniR-Bahmni wants to merge 5 commits intomasterfrom
Open
BAH-4504 Add support for additional section on registration create patient page#95hamsavarthiniR-Bahmni wants to merge 5 commits intomasterfrom
hamsavarthiniR-Bahmni wants to merge 5 commits intomasterfrom
Conversation
sumaztwcode
reviewed
Mar 26, 2026
| "REGISTRATION_SECTION_CONTACT_DETAILS": "Contact information", | ||
| "REGISTRATION_SECTION_ADDITIONAL_INFO": "Additional information", | ||
| "REGISTRATION_SECTION_IDENTIFIERS": "Additional Identifiers", | ||
| "REGISTRATION_SECTION_RELATIONSHIPS": "Relationships Information" |
There was a problem hiding this comment.
It should be "Relationship" in the translated text
sumaztwcode
reviewed
Mar 26, 2026
| "REGISTRATION_PHONE_NUMBER_VALIDATION": "Phone number should be numbers between 6 to 15 digits", | ||
| "REGISTRATION_ALTERNATE_PHONE_NUMBER_VALIDATION": "Alternate phone number should be numbers between 6 to 15 digits" | ||
| "REGISTRATION_ALTERNATE_PHONE_NUMBER_VALIDATION": "Alternate phone number should be numbers between 6 to 15 digits", | ||
| "REGISTRATION_SECTION_BASIC_INFO": "Basic Information", |
There was a problem hiding this comment.
Maintain consistency with design file - in all headers second word starts with small letter e.g "Basic information"
sumaztwcode
requested changes
Mar 26, 2026
PratitiP
reviewed
Mar 30, 2026
| "titleTranslationKey": "REGISTRATION_SECTION_CONTACT_DETAILS" | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Fields on the respective sections looks little bit scattered. We need to look into patientInformation section to check which fields are there in the additionalInfo.
As discussed we can take this in upcoming cards. Also we should consider a scenario, where we might need multiple additional information sections. So which fields go in which additional info sections should be coupled some how
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.